Skip to content

Raajb/basevsa #3622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 10, 2019
Merged

Raajb/basevsa #3622

merged 3 commits into from
Dec 10, 2019

Conversation

rocketsofthsv
Copy link
Contributor

No description provided.

@rocketsofthsv
Copy link
Contributor Author

@mairaw

@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label Dec 4, 2019
@mairaw mairaw added this to the December 2019 milestone Dec 4, 2019
@mairaw mairaw self-requested a review December 4, 2019 07:15
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rocketsofthsv! Left a few suggestions for you to take care that can be batched in a single commit via https://github.com/dotnet/dotnet-api-docs/pull/3622/files

@rocketsofthsv
Copy link
Contributor Author

@mairaw done!

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rocketsofthsv! Looks good!

@mairaw mairaw merged commit ee94535 into dotnet:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vendor-project Indicates the issue/pr is related to a vendor project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants